Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optipng on some CI workflow targets #83

Open
smarie opened this issue Nov 21, 2023 · 0 comments
Open

Add optipng on some CI workflow targets #83

smarie opened this issue Nov 21, 2023 · 0 comments

Comments

@smarie
Copy link
Owner

smarie commented Nov 21, 2023

Fixes relative to optipng, such as #77, are not currently tested in CI:

WARNING - optipng binaries not found, PNG images and thumbnails will not be optimized

https://github.com/smarie/mkdocs-gallery/actions/runs/6928047749/job/18843066689?pr=77#step:6:125

Unfortunately optipng cannot be installed by pip. We therefore have to modify the github actions workflow to install it.

Maybe just doing some apt-get on the ubuntu targets would be enough ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smarie