Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANDROID] Promise is not resolving on second time paying. #67

Closed
dkfl1995 opened this issue Dec 28, 2020 · 7 comments
Closed

[ANDROID] Promise is not resolving on second time paying. #67

dkfl1995 opened this issue Dec 28, 2020 · 7 comments

Comments

@dkfl1995
Copy link
Contributor

dkfl1995 commented Dec 28, 2020

Hi guys.
Few days ago started with upgrading BT SDK from 2.17 to latest 3.14.2 as faced Google Play team warning like related to this issue.
Found really disgusting issue right there then after upgrading. If you use like new 3.14.2 BT SDK version promise on requestOneTimePayment native method still remains the same each time you trigger this method. This lead to promise to be useless as it won't run resolve or reject on second request and then. HashCode of promise still remains the same. As on BT SDK v2.17 promise has different HashCode each time you trigger requestOneTimePayment method.

@krupalikevadiya
Copy link

Yes found same issue in android only.Have you found any solution for it?

@dkfl1995
Copy link
Contributor Author

@krupalikevadiya actually, having a talk with PayPal development team so they researching this issue. Once I will get any response, will write right there

@valerio-fornace
Copy link

Are there any kind of news about this issue?

@nzankich
Copy link
Contributor

nzankich commented Feb 6, 2021

@valerio-fornace There's an open MR that needs a tweak but it should be ready to go after that. If I don't get a response for a few days I'll finish up the fix and do a release

@valerio-fornace
Copy link

@nzankich thanks this is a good news!

@nzankich
Copy link
Contributor

fixed on 4.0.1

be sure to follow the upgrade instructions for 4.0.0 https://github.com/smarkets/react-native-paypal/releases/tag/4.0.0

@Talha-Jawed
Copy link

@nzankich
still getting same issue in android.

"react-native": "0.64.2",
"react-native-paypal": "4.1.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants