Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable pdf export and automatically upload to ipfs #7

Merged
merged 3 commits into from
Mar 14, 2022
Merged

enable pdf export and automatically upload to ipfs #7

merged 3 commits into from
Mar 14, 2022

Conversation

emilianobonassi
Copy link
Contributor

adding support to export to pdf, so it's easier to read offline (e.g. Kindle) and automatically update to ipfs

@netlify
Copy link

netlify bot commented Mar 12, 2022 •
edited
Loading

✔️ Deploy Preview for eth2book ready!

🔨 Explore the source changes: 02aa4d5

🔍 Inspect the deploy log: https://app.netlify.com/sites/eth2book/deploys/622f51abdce8000008bb319f

😎 Browse the preview: https://deploy-preview-7--eth2book.netlify.app

@smartcontracts
Copy link
Owner

Wow, this is awesome. Let me test this locally.

@smartcontracts smartcontracts added the enhancement New feature or request label Mar 12, 2022
@smartcontracts
Copy link
Owner

Ok sweet, just need to resolve the last merge conflicts and we can get this merged (might be easiest to simply remove yarn.lock and regenerate it). Thank you! This is sick.

@emilianobonassi
Copy link
Contributor Author

yeah, currently on mobile, will resolve tomorrow

great job the book!

@smartcontracts
Copy link
Owner

smartcontracts commented Mar 12, 2022 •
edited
Loading

yeah, currently on mobile, will resolve tomorrow

great job the book!

No rush at all. And thank you, it's still a work in progress but starting to ramp back up again :-) Hit me with an ETH address and I'll send you a contributor NFT!

@emilianobonassi
Copy link
Contributor Author

@smartcontracts conflicts managed, ready to go!

here my ENS: emiliano.eth

smartcontracts
smartcontracts reviewed Mar 14, 2022
View reviewed changes
crowdin.yml Outdated Show resolved Hide resolved
smartcontracts
smartcontracts approved these changes Mar 14, 2022
View reviewed changes
Copy link
Owner

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@smartcontracts smartcontracts merged commit 22aa6a4 into smartcontracts:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilianobonassi @smartcontracts