From f3354171e4f044c669b99afefd8fac5e2cd99783 Mon Sep 17 00:00:00 2001 From: Ashish Keshan Date: Mon, 21 Oct 2024 11:36:02 -0700 Subject: [PATCH] Fix for unused reusable script (#52591) --- .github/workflows/orphaned-files-check.yml | 2 +- .../scripts/reusables-cli/find/unused.ts | 13 ++++++++++--- src/content-render/scripts/reusables-cli/shared.ts | 1 + 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/orphaned-files-check.yml b/.github/workflows/orphaned-files-check.yml index 117e57445367..0aa347f33ec7 100644 --- a/.github/workflows/orphaned-files-check.yml +++ b/.github/workflows/orphaned-files-check.yml @@ -24,7 +24,7 @@ permissions: contents: read jobs: - orphaned-assets-check: + orphaned-files-check: if: ${{ github.repository == 'github/docs-internal' }} runs-on: ubuntu-latest steps: diff --git a/src/content-render/scripts/reusables-cli/find/unused.ts b/src/content-render/scripts/reusables-cli/find/unused.ts index 7d2dc342f500..70e6d54574e2 100644 --- a/src/content-render/scripts/reusables-cli/find/unused.ts +++ b/src/content-render/scripts/reusables-cli/find/unused.ts @@ -24,10 +24,17 @@ export function findUnused({ absolute }: { absolute: boolean }) { const liquidTokens = getLiquidTokens(fileContents) for (const token of liquidTokens) { const { args, name } = token - if (name === 'data' && args.startsWith('reusables.')) { - const reusableName = path.join('data', ...args.split('.')) + '.md' + if ( + (name === 'data' || name === 'indented_data_reference') && + args.startsWith('reusables.') + ) { + const reusableName = path.join('data', ...args.split(' ')[0].split('.')) + '.md' // Special cases where we don't want them to count as reusables. It's an example in a how-to doc - if (reusableName.includes('foo/bar.md') || reusableName.includes('your-reusable-name.md')) { + if ( + reusableName.includes('foo/bar.md') || + reusableName.includes('foo/par.md') || + reusableName.includes('your-reusable-name.md') + ) { continue } const reusablePath = resolveReusablePath(reusableName) diff --git a/src/content-render/scripts/reusables-cli/shared.ts b/src/content-render/scripts/reusables-cli/shared.ts index e42dc25de6fc..0c12288d4388 100644 --- a/src/content-render/scripts/reusables-cli/shared.ts +++ b/src/content-render/scripts/reusables-cli/shared.ts @@ -105,6 +105,7 @@ export function getAllReusablesFilePaths(): string[] { walk(reusablesDirectory, { includeBasePath: true, directories: false, + ignore: ['**/README.md', 'enterprise_deprecation/**'], }), ) }