Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and Improvements #100

Open
4512369781 opened this issue Dec 1, 2024 · 10 comments
Open

Fixes and Improvements #100

4512369781 opened this issue Dec 1, 2024 · 10 comments
Assignees

Comments

@4512369781
Copy link

4512369781 commented Dec 1, 2024

Made some fixes to "manual attack", mainly to fix the issue with bots not fire, added some new settings, and some other tweaks.

update: fixandimprove_new2.zip

  1. Add new setting: manual_attack_saccade_speed
  2. Minor adjustments
  3. Optimize find common infected
@Mystik-Spiral
Copy link

@4512369781 That is an impressive list of modifications! If time allows, I may put this on my test server and try it out.

@smilz0
Copy link
Owner

smilz0 commented Dec 3, 2024

Thanks man. That is a lot of stuff, it'll take some time to test.
Btw what is the bug of the bots not shooting? I never noticed it.

@4512369781
Copy link
Author

Thanks man. That is a lot of stuff, it'll take some time to test. Btw what is the bug of the bots not shooting? I never noticed it.

I spawned infected near the bots and found that they would randomly stop shooting, which reminded me of someone said bots just watched and didn't shoot to save him from charger. Finally, I sure that this bug is happen when "manual attack" is keep working, and the bots will not shoot again until there are no infected around and "manual attack" stops. So I adjust the way to set "m_isHoldingFireButton" to fix this problem.

@smilz0
Copy link
Owner

smilz0 commented Dec 5, 2024

Thanks man. That is a lot of stuff, it'll take some time to test. Btw what is the bug of the bots not shooting? I never noticed it.

I spawned infected near the bots and found that they would randomly stop shooting, which reminded me of someone said bots just watched and didn't shoot to save him from charger. Finally, I sure that this bug is happen when "manual attack" is keep working, and the bots will not shoot again until there are no infected around and "manual attack" stops. So I adjust the way to set "m_isHoldingFireButton" to fix this problem.

Oh ok thanks.
One more question:
how would you set the default values of the new manual_attack settings for Advanced and Expert difficulties?

@Mystik-Spiral
Copy link

I did not have enough time to do a proper test, so this is just feedback on my quick testing after adding your file to the VPK. I did not notice any functional difference. I did not notice any situations where the bots stop shooting, but I have occasionally noticed this in the past. However, I found that was mostly, but not entirely, due to a conflict with a SourceMod plugin (Survivor Bot AI Improver). This setting in particular:

// Makes survivor bots force attack pinned survivor's SI if possible. <0: Disabled, 1: Shoot at attacker, 2: Shove the attacker if close enough. Add numbers together.>
// -
// Default: "3"
// Minimum: "0.000000"
// Maximum: "3.000000"
ib_help_pinned_enabled "1"

When set to to 2 or 3 they would sometimes do nothing (or try shoving Chargers), so I set it to 1 (always shoot SI with pinned survivor) and it mostly resolved that issue.

With that said, I believe the "no shooting" problem happens mostly with tanks. The bot has a weapon with ammo, but they will sometimes stop shooting and equip their melee weapon (but not attack with it). The bots will often just stand still (hide) when the tank is not visible, even if the tank is nearby and attacking a survivor, like around a corner... they will not seek out the tank to attack it.

For proper testing I would need to disable all of my SourceMod plugins to ensure there are no issues being caused due to conflicts. However, I will be traveling a LOT this month and will not be able to do any further testing. I will check back after the holidays to see what the current status is.

Thanks to everyone that has created or contributed improvements to this project!

@4512369781
Copy link
Author

@smilz0
Advanced
manual_attack_dual_pistol_nerf = 1
manual_attack_wandering = 0
manual_attack_common_head_radius = 300
manual_attack_special_head_radius = 300

Expert
manual_attack_dual_pistol_nerf = 0
manual_attack_wandering = 1
manual_attack_common_head_radius = 450
manual_attack_special_head_radius = 400

At higher difficulties, common infected are more dangerous, so I set it farther away.

@4512369781
Copy link
Author

@Mystik-Spiral
This is mainly a bug fix, so it's not much different than before.
I don't remember seeing bots switch to melee when fighting a tank alone, but they will do so when there are common infected around. The other issue may caused by "tank_retreat_radius" settings, once the bots get close, they are ordered to retreat, so they always keep a safe distance and cannot attack when they hold a melee.
Thanks for your feedback!

@4512369781
Copy link
Author

@smilz0
I updated some stuff, feel free to test it.

@smilz0
Copy link
Owner

smilz0 commented Dec 13, 2024

@smilz0 I updated some stuff, feel free to test it.

This is very nice, especially the smoother aim. Good job man.
I did a few tests, i haven't seen any bug. When i can i will merge the changes and update the "out" vpk.

@4512369781
Copy link
Author

This is very nice, especially the smoother aim. Good job man. I did a few tests, i haven't seen any bug. When i can i will merge the changes and update the "out" vpk.

Glad you like it!
I wanted to do this when I first made the aiming feature, but there has some problems were not solved until now, and the addition of tolerance also makes the bots less accurate, totally it will be weaker than before. But at full power settings, two bots finally escape the Dead Center on expert difficulty after two rounds restarts, I think is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants