Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove existing from_request/into_response methods #1706

Closed
hlbarber opened this issue Sep 5, 2022 · 1 comment
Closed

Remove existing from_request/into_response methods #1706

hlbarber opened this issue Sep 5, 2022 · 1 comment
Labels
server Rust server SDK

Comments

@hlbarber
Copy link
Contributor

hlbarber commented Sep 5, 2022

Following #1693 the new FromRequest/IntoResponse/FromParts implementations defer to the original from_request/into_response methods. These original methods are used in conjunction with the inlineable::server_operation_handler_trait::Handler trait to achieve the current service builder.

Eventually, when the original service builder is removed, along with the inlineable Handler, the original from_request/into_response methods will become an additional unused interface.

Work could be done incrementally and eagerly to unify these interfaces internally prior to the deprecation/removal of the original service builder.

@hlbarber
Copy link
Contributor Author

#2161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Rust server SDK
Projects
None yet
Development

No branches or pull requests

2 participants