Add middleware documentation #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlbarber
added
documentation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
crisidev
reviewed
Oct 13, 2022
|
|
||
| where `UpgradeLayer` is the `Layer` converting Smithy model structures to HTTP structures and the `RoutingService` is responsible for routing requests to the appropriate operation. | ||
|
|
||
| ### A) Outer Middleware |
There was a problem hiding this comment.
While I understand it, I believe the difference between A) and B) is not clear in the doc.
There was a problem hiding this comment.
Hows this?
debae27
added 2 commits
October 13, 2022 17:44
hlbarber
force-pushed
the
harryb/middleware-docs
branch
from
baf1ca4
to
debae27
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
unexge
reviewed
Oct 20, 2022
unexge
approved these changes
Oct 20, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There is currently no description on where and how a customer can apply
Layer.Description
Rendered
Add a
middleware.mddocument.Notes
This describes the new service builder API and therefore will remain hidden until its official release.