New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PowerPC architecture for sigv4 signature #1847

Merged

LukeMathWalker merged 37 commits into main from powerpc-signature

Oct 25, 2022

Contributor

crisidev commented Oct 13, 2022 •

edited by LukeMathWalker

Loading

Motivation and Context

aws-sigv4 crate does not compile on PowerPC because of ring. This PR adds support PowerPC by using hmac and sha2 instead of ring.

I have also improved the CI to run as many tests as we can in the runtime crates. Some tests as been disabled under 32bit architectures, see #1857 .

Testing

Unit tests are passing using cross. CI will run all the tests as well.

I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates
I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

crisidev added 2 commits

October 13, 2022 18:31


          Use hmac and sha2 instead of ring on powerpc

61835a0


          Enable aws-sig-auth in CI

crisidev requested review from a team as code owners

October 13, 2022 17:10

crisidev added 3 commits

October 13, 2022 18:11


          Merge branch 'main' into powerpc-signature

da7f6e3


          Update CHANGELOG

bae218e


          Run tests against exotic platforms

ec00348

crisidev commented

View reviewed changes

CHANGELOG.next.toml Outdated Show resolved Hide resolved

github-actions bot commented Oct 13, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.


          Run tests only against aws rust runtime

0495c3d

github-actions bot commented Oct 13, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

LukeMathWalker reviewed

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

LukeMathWalker reviewed

View reviewed changes

aws/rust-runtime/aws-sigv4/Cargo.toml Outdated Show resolved Hide resolved


          PowerPC 32 and 64 bit should be fully testable now

613651e

github-actions bot commented Oct 14, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

crisidev added 4 commits

October 14, 2022 15:12


          Maybe this time build and test will work

47a5cff


          Add licence header to hmac.rs

29fe967


          Properly use finalized_fixed

3ad7f87


          Revert leftover

c66627d

github-actions bot commented Oct 14, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.


          Temporary disable crc32c test on powerpc

f31b017

github-actions bot commented Oct 14, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.


          Temporary disable system_time_conversion_test on 32bit CPUs

fe5cf98

github-actions bot commented Oct 14, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

crisidev added 3 commits

October 14, 2022 17:22


          Disable other 3 tests on 32bit

8f72a33


          Merge branch 'main' into powerpc-signature

98e5674


          Temporarily disable last test

b2ed396

github-actions bot commented Oct 14, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

crisidev mentioned this pull request

Fix skipped tests on PowerPC 32/64 and i686 #1857

Open


          Update CHANGELOG and document TODOs with issues

078700f


          Merge branch 'main' into powerpc-signature

0ec0f98

github-actions bot commented Oct 18, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

LukeMathWalker added 3 commits

October 21, 2022 15:42


          Add tcp feature to hyper to get tests compiling.

f12edb9


          Enable verbose logging to debug CI failure in cross.

03a6ded


          Merge branch 'main' into powerpc-signature

0d32d56

github-actions bot commented Oct 21, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

LukeMathWalker added 2 commits

October 21, 2022 17:20


          Use pre-built openSSL on i686

f45401b


          Fix empty spaces.

6084fde

github-actions bot commented Oct 21, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Server Test (ignoring whitespace)
No codegen difference in the Server Test Python

A new doc preview is ready to view.


          Merge branch 'main' into powerpc-signature

6df5d6e

github-actions bot commented Oct 21, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.


          Set environment variables based on matrix.target

0df6cfc

github-actions bot commented Oct 21, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

LukeMathWalker added 3 commits

October 25, 2022 12:48


          Remove all usages of ring from aws-sigv4. It ensures broader plat…

bea53b6

…form compatibility and higher performance.


          Update changelog entries.

299120d


          Merge branch 'main' into powerpc-signature

0f10bbe

LukeMathWalker approved these changes

View reviewed changes

LukeMathWalker added the needs-sdk-review label

github-actions bot commented Oct 25, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.


          Merge branch 'main' into powerpc-signature

f6e84e8

github-actions bot commented Oct 25, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

Velfi approved these changes

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

aws/rust-runtime/aws-sigv4/Cargo.toml Outdated Show resolved Hide resolved

Velfi removed the needs-sdk-review label


          Remove redundant dev dependencies.

f9e96d4

LukeMathWalker enabled auto-merge (squash)

October 25, 2022 16:03

github-actions bot commented Oct 25, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.


          Merge branch 'main' into powerpc-signature

e6ab7e6

github-actions bot commented Oct 25, 2022

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python

A new doc preview is ready to view.

LukeMathWalker merged commit 7e666da into main

LukeMathWalker deleted the powerpc-signature branch

October 25, 2022 17:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet