Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish PokemonService generated server crate to crates.io #2014

Open
hlbarber opened this issue Nov 21, 2022 · 4 comments
Open

Publish PokemonService generated server crate to crates.io #2014

hlbarber opened this issue Nov 21, 2022 · 4 comments
Labels
documentation Improvements or additions to documentation server Rust server SDK

Comments

@hlbarber
Copy link
Contributor

hlbarber commented Nov 21, 2022

Publishing the crate would trigger a docs.rs build. This would allow the aws-smithy-http-server documentation, and documentation in general, to reference generated items.

@hlbarber hlbarber added documentation Improvements or additions to documentation server Rust server SDK labels Nov 21, 2022
@david-perez
Copy link
Contributor

What generated items would we reference from aws-smithy-http-server?

@hlbarber
Copy link
Contributor Author

hlbarber commented Nov 23, 2022

In some cases types from aws-smithy-http-server are used in the context of a generated API.

For example:

  • MakeServiceWithConnectInfo is a product of the make_service_with_connect_info on the generated service.
  • Operations are passed to the operation setters.
  • Plugins are passed to build_with_plugins.

@david-perez
Copy link
Contributor

To avoid aws-smithy-http-server taking a dev dependency on a generated SDK like the Pokémon service's (which is sizable and could slow down compilation), an alternative is to have the book depend on the generated SDK and have aws-smithy-http-server + the user's generated SDK link to the book.

@hlbarber
Copy link
Contributor Author

I think this can be deprioritized now that we have #2027 which allows us to write examples involving the examples workspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation server Rust server SDK
Projects
None yet
Development

No branches or pull requests

2 participants