Add SharedAsyncSleep wrapping Arc<dyn AsyncSleep> #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysaito1001
added
the
breaking-nominated-q2
ysaito1001
added
breaking-change
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Jun 2, 2023
Co-authored-by: John DiSanti <jdisanti@amazon.com>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This commit addresses #2742 (comment)
jdisanti
approved these changes
Jun 2, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add
SharedAsyncSleepwrappingArc<dyn AsyncSleep>and update call sites ofArc<dyn AsyncSleep>to useSharedAsyncSleepDescription
Public APIs that take/return a trait object for
AsyncSleephave been usingArc<dyn AsyncSleep>in the codebase. This has a downside of exposing a bareArc, making it difficult to change the APIs in the future without breaking backwards compatibility. This PR adds a newtype wrapperSharedAsyncSleepthat hidesArc<dyn AsyncSleep>to alleviate the said issue (the idiom of havingSharedXXXhas been seen in the codebase, e.g.SharedTimeSource,SharedCredentialsProvider, and so on).Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.