Feature-gate http versions in aws-smithy-runtime-api #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
feature-gate-http02x
branch
from
60b1476
to
0bb183f
Compare
jdisanti
reviewed
Nov 17, 2023
Comment on lines
289
to
293
|
|
||
| #[allow(dead_code)] | ||
| pub(crate) fn into_http1x(self) -> http1::HeaderValue { | ||
| http1::HeaderValue::from_bytes(self._private.as_bytes()).expect("proven valid") | ||
| } |
There was a problem hiding this comment.
Suggested change
| #[allow(dead_code)] | |
| pub(crate) fn into_http1x(self) -> http1::HeaderValue { | |
| http1::HeaderValue::from_bytes(self._private.as_bytes()).expect("proven valid") | |
| } |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Nov 17, 2023
ysaito1001
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Without this, we will have http = 0.2 permanently in-tree.
Description
Add http 1x as an experiment.Testing
CI
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.