Allow lossless conversions from float into integral types #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
lossless-runtime-conversions
branch
from
76378d1
to
f082228
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
reviewed
Dec 7, 2023
rcoh
force-pushed
the
lossless-runtime-conversions
branch
from
f082228
to
dcbd671
Compare
jdisanti
approved these changes
Dec 7, 2023
|
Looks good. Don't forget the changelog entry. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
approved these changes
Dec 7, 2023
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some APIs return JSON values that are intended to be represented by integral types but are returned as floating values e.g
[1.0, -2.0, 25.0].This allows those values to be converted into Integral types.
Description
This uses a bidirectional conversion to check if a float can be losslessly converted into a integral type. This can have issues at the limits of i64::MAX but I think that's probably acceptable. These values would be represented imprecisely by floats already.
Testing
Added additional unit tests of the behavior.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.