Support stringArray type in endpoints params
#3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Changelog
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Jul 8, 2024
.../smithy/rust/codegen/client/smithy/endpoint/generators/EndpointParamsInterceptorGenerator.kt
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Jul 8, 2024
...n/kotlin/software/amazon/smithy/rust/codegen/client/testutil/ClientCodegenIntegrationTest.kt
Outdated
Show resolved
Hide resolved
Velfi
reviewed
Jul 8, 2024
.../kotlin/software/amazon/smithy/rust/codegen/client/smithy/endpoint/EndpointsDecoratorTest.kt
Show resolved
Hide resolved
Velfi
reviewed
Jul 8, 2024
.../kotlin/software/amazon/smithy/rust/codegen/client/smithy/endpoint/EndpointsDecoratorTest.kt
Outdated
Show resolved
Hide resolved
…egen/client/smithy/endpoint/EndpointsDecoratorTest.kt Co-authored-by: Zelda Hessler <zhessler@amazon.com>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Jul 8, 2024
.../smithy/rust/codegen/client/smithy/endpoint/generators/EndpointParamsInterceptorGenerator.kt
Outdated
Show resolved
Hide resolved
Velfi
approved these changes
Jul 8, 2024
…egen/client/smithy/endpoint/generators/EndpointParamsInterceptorGenerator.kt Co-authored-by: Zelda Hessler <zhessler@amazon.com>
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Updated our endpoint rule generation to support the new
stringArrayparameter typeTesting
Updated the existing
EndpointsDecoratorTestwith tests forstringArrayChecklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.