Add support for operationContextParams Endpoints trait
#3755
Conversation
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
.../smithy/rust/codegen/client/smithy/generators/waiters/RustJmespathShapeTraversalGenerator.kt
Outdated
Show resolved
Hide resolved
| @@ -194,6 +216,8 @@ class EndpointsDecoratorTest { | |||
| .map(ToString::to_string) | |||
| .collect::<Vec<_>>() | |||
| ) | |||
| .jmes_path_param_string_array(vec!["key2".to_string(), "key1".to_string()]) | |||
There was a problem hiding this comment.
question: are these jmes_path_param_* functions internal or public?
There was a problem hiding this comment.
Probably pub since they're methods on service-specific endpoint params builder.
There was a problem hiding this comment.
Correct, they are pub since they are part of the param builder. Normally they won't have the jmes_path_param_ prefix, thats just because I named them like that in the model:
@operationContextParams(
JmesPathParamString: {
path: "nested.field",
}
JmesPathParamBoolean: {
path: "nested.boolField",
}
JmesPathParamStringArray: {
path: "keys(nested.mapField)",
}
)We could make them private with the assumption that these should only be set by the generated JMESPath getters, but we allow overriding other values set in the model (mostly those on staticContextParams) so it seemed most consistent to keep that behavior.
And fix a test that was flaky because of non-deterministic hashmap key ordering
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
We have to support the new
operationContextParamstrait for endpoint resolution. This trait specifies JMESPath expressions for selecting parameter data from the operation's input type.Description
keysfunction (required by the trait spec)get_param_namefunctions for each param specified inoperationContextParams. These functions pull the data out of the input object and it is added to the endpoint params in the${operationName}EndpointParamsInterceptorTesting
Updated the existing test suite for JMESPath codegen to test the
keysfunction. Updated the existing EndpointsDecoratorTest with anoperationContextParamstrait specifying one param of each supported type to test the codegen.Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.