Fix Length::UpTo
usage in FsBuilder
so it does not exceed available file length
#3797
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
awslabs/aws-sdk-rust#821
Description
This PR addresses an issue with the Length::UpTo usage in
FsBuilder
. Previously, if a value specified forUpTo
exceeded the remaining file length,FsBuilder
would incorrectly accept the value. This discrepancy led to failures in subsequent request dispatches, as the actual body size did not match the advertisedContent-Length
, as explained here (thank you @pablosichert for a self-contained reproducer and problem analysis!).Testing
FsBuilder
verifying theLength::UpTo
usagecomplete_multipart_upload
at the end, it also succeeded in uploading the object):Checklist
.changelog
directory, specifying "client," "server," or both in theapplies_to
key..changelog
directory, specifying "aws-sdk-rust" in theapplies_to
key.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.