-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server codegen flag addValidationExceptionToConstrainedOperations #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to include ValidationException in constrained operations.
drganjoo
changed the title
Add server codegen flag addValidationExceptionToConstrainedOperations…
Add server codegen flag addValidationExceptionToConstrainedOperations
Aug 27, 2024
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
drganjoo
force-pushed
the
fahadzub/add-validation
branch
from
August 28, 2024 09:53
bc58bd1
to
0ecfce8
Compare
drganjoo
force-pushed
the
fahadzub/add-validation
branch
from
August 28, 2024 09:55
0ecfce8
to
d254283
Compare
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
approved these changes
Aug 28, 2024
.../src/main/kotlin/software/amazon/smithy/rust/codegen/core/testutil/CodegenIntegrationTest.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/software/amazon/smithy/rust/codegen/core/testutil/CodegenIntegrationTest.kt
Outdated
Show resolved
Hide resolved
...rver/smithy/transformers/AttachValidationExceptionToConstrainedOperationInputsInAllowList.kt
Outdated
Show resolved
Hide resolved
...rver/smithy/transformers/AttachValidationExceptionToConstrainedOperationInputsInAllowList.kt
Show resolved
Hide resolved
...st/codegen/server/smithy/customizations/AddValidationExceptionToConstrainedOperationsTest.kt
Outdated
Show resolved
Hide resolved
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Server SDK requires the model to include
aws.smithy.framework#ValidationException
in each operation that can access a constrained member shape. This becomes problematic when generating the server SDK for a model not owned by the team creating the SDK, as they cannot easily modify the model.This PR introduces a codegen flag,
addValidationExceptionToConstrainedOperations
. When set insmithy-build-template.json
, this flag will automatically addValidationException
to operations that require it but do not already list it among their errors.Closes Issue: 3802
Sample
smithy-build-template.json