Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smithy Swift support for VisionOS #603

Closed
2 tasks done
lastw0nd3r opened this issue Oct 18, 2023 · 5 comments
Closed
2 tasks done

Smithy Swift support for VisionOS #603

lastw0nd3r opened this issue Oct 18, 2023 · 5 comments
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@lastw0nd3r
Copy link

Describe the feature

Wondering if you guys can add support for visionOS, should work the same way for iOS as you aren't using UIKit.

Use Case

I was trying to use AWS-SDK and it's referencing (as a package dependency) to smithy swift. But, the latest/any version doesn't support visionOS.

Maybe you can add an #elseif in PlatformOperatingSystem.swift (should behave the same way as iOS).

Proposed Solution

Maybe you can add an #elseif in PlatformOperatingSystem.swift (should behave the same way as iOS).

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@lastw0nd3r lastw0nd3r added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 18, 2023
@dayaffe
Copy link
Collaborator

dayaffe commented Oct 19, 2023

Thanks for your issue, we'll look into it & will update this issue when we have more info

@dayaffe dayaffe removed the needs-triage This issue or PR still needs to be triaged. label Oct 20, 2023
@dayaffe dayaffe self-assigned this Oct 20, 2023
@dayaffe
Copy link
Collaborator

dayaffe commented Oct 20, 2023

We're going to allow the SDK to compile and you can expect this to be in the next release! However, we do not guarantee that it will work and cannot provide additional support at this time. Please let us know how it goes!

(Will leave this ticket open until it is released)

@dayaffe dayaffe closed this as completed Oct 20, 2023
@dayaffe dayaffe reopened this Oct 20, 2023
@lastw0nd3r
Copy link
Author

I have tried changing the header file in here to use "iOS" for "VisionOS" in the switch in PlatformOperatingSystem.swift and it works as expected. So, I believe if you'd keep "iOS" / "VisionOS" pointing to the same OS in that switch. That should be it.

Thanks

@jbelkins
Copy link
Contributor

@lastw0nd3r In AWS SDK for Swift 0.29.0 (released today), we have added visionOS as a PlatformOperatingSystem option.

We are adding it for experimentation purposes only and are not committing to long-term support of visionOS. However, the changes we have made should allow the SDK to at least compile successfully when linked into a visionOS app.

Please feel free to share your feedback or file further issues regarding your experience with the SDK.

@lastw0nd3r
Copy link
Author

Sure, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants