Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The separator in case of headers with list values #1014

Closed
trivikr opened this issue Dec 10, 2021 · 2 comments
Closed

The separator in case of headers with list values #1014

trivikr opened this issue Dec 10, 2021 · 2 comments
Labels
guidance Question that needs advice or information. protocol-test New protocol tests are needed

Comments

@trivikr
Copy link
Contributor

trivikr commented Dec 10, 2021

RestJsonInputAndOutputWithStringHeaders

The protocol test RestJsonInputAndOutputWithStringHeaders was using space as a separator for headers with list values.
https://github.com/awslabs/smithy/blob/78a3ac958ea442695cf66ad0f5808768e1f553bf/smithy-aws-protocol-tests/model/restJson1/http-headers.smithy#L31-L48

  • input: headerStringList: ["a", "b", "c"],
  • output: "X-StringList": "a, b, c",

RestJsonInputAndOutputWithQuotedStringHeaders

The new protocol test for quoted strings RestJsonInputAndOutputWithQuotedStringHeaders removes this separator
https://github.com/awslabs/smithy/blob/78a3ac958ea442695cf66ad0f5808768e1f553bf/smithy-aws-protocol-tests/model/restJson1/http-headers.smithy#L49-L63

  • input: headerStringList: ["b,c", "\"def\"", "a"]
  • output:
"X-StringList": """
            "b,c","\"def\"",a"""

If the whitespace separator needs to be used, the output should be:

"X-StringList": """
            "b,c", "\"def\"", a"""

Question

What separator should be used in case of headers with list values?

Additional Context

@jvschneid jvschneid added the guidance Question that needs advice or information. label Jul 24, 2023
@kstich kstich added the protocol-test New protocol tests are needed label Aug 14, 2023
@kstich
Copy link
Contributor

kstich commented Aug 21, 2023

This was fixed in #1049

@kstich kstich closed this as completed Aug 21, 2023
@kuhe
Copy link
Contributor

kuhe commented Sep 26, 2024

I think this was actually talking about the inconsistent spacing accompanying the delimiter , vs ,, and not the fixed issue which was the ordering of the values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information. protocol-test New protocol tests are needed
Projects
None yet
Development

No branches or pull requests

4 participants