Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateDedicatedInputAndOutput leaves orphaned shapes in some cases #1373

Closed
jdisanti opened this issue Aug 29, 2022 · 0 comments
Closed

CreateDedicatedInputAndOutput leaves orphaned shapes in some cases #1373

jdisanti opened this issue Aug 29, 2022 · 0 comments
Labels
bug This issue is a bug.

Comments

@jdisanti
Copy link
Contributor

Consider the following Smithy model:

        namespace test
        operation GenerateSpeech {
            output: GenerateSpeechOutput,
            input: GenerateSpeechOutput
        }

        structure GenerateSpeechOutput {
            data: BlobStream
        }

        @streaming
        blob BlobStream

The CreateDedicatedInputAndOutput model transformer (with suffixes “Input” and “Output”) will create GenerateSpeechInput and GenerateSpeechOperationOutput structures to replace the input/output on that operation. However, when it does so, it does NOT remove GenerateSpeechOutput from the model when it should because it gets confused into thinking it’s not a singular reference due to the original unmutated operation’s input referencing it. However, it is a singular reference because it replaced that input with GenerateSpeechInput.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants