Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonFinalizedTree::finality_checkpoints is wrong if there's more than one non-finalized epoch #1042

Closed
tomaka opened this issue Aug 17, 2023 · 0 comments · Fixed by #1127
Closed

NonFinalizedTree::finality_checkpoints is wrong if there's more than one non-finalized epoch #1042

tomaka opened this issue Aug 17, 2023 · 0 comments · Fixed by #1127
Labels
priority-low

Comments

@tomaka
Copy link
Contributor

tomaka commented Aug 17, 2023

NonFinalizedTree::finality_checkpoints is supposed to return the blocks that must be finalized first things first.
However, it can return blocks whose ancestor is also a finality checkpoint. This is wrong and not intended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NonFinalizedTree::finality_checkpoints and add caches tomaka/smoldot
1 participant
@tomaka