Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyclic reference in JSON-RPC service #406

Closed
tomaka opened this issue Apr 11, 2023 · 2 comments
Closed

Cyclic reference in JSON-RPC service #406

tomaka opened this issue Apr 11, 2023 · 2 comments

Comments

@tomaka
Copy link
Contributor

tomaka commented Apr 11, 2023

The tasks hold an Arc to Background, which holds an Arc to the request_responses, which itself holds the tasks.
Even if the JSON-RPC service is free'd, the Arcs stay alive.
This was referenced Apr 11, 2023
Merged
Closed
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Apr 11, 2023

Unfortunately not fixed after #407 and #409

Can be reproduced by connecting to many chains then removing them and observing the memory usage.

@tomaka tomaka mentioned this issue Apr 11, 2023
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Apr 12, 2023

Now fixed after #409

@tomaka tomaka closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka