Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer use the log crate in light-base #756

Closed
tomaka opened this issue Jun 16, 2023 · 1 comment · Fixed by #1560
Closed

No longer use the log crate in light-base #756

tomaka opened this issue Jun 16, 2023 · 1 comment · Fixed by #1560

Comments

@tomaka
Copy link
Contributor

tomaka commented Jun 16, 2023

Instead, the PlatformRef trait should get a log function.

@tomaka
Copy link
Contributor Author

tomaka commented Aug 18, 2023

Most likely API:

    fn log<'a>(
        &'a self,
        log_level: LogLevel,
        target: &str,
        text: &str,
        parameters: &mut dyn Iterator<Item = (&'a str, fmt::Arguments<'a>)>,
    );

The only problem is it's not clear to me how the default platform should behave. I suppose that it should use the log crate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant