Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throughput has decreased drastically after polling updates #990

Closed
ryan-summers opened this issue Sep 12, 2024 · 0 comments · Fixed by #991
Closed

Throughput has decreased drastically after polling updates #990

ryan-summers opened this issue Sep 12, 2024 · 0 comments · Fixed by #991

Comments

@ryan-summers
Copy link
Contributor

According to @thvdveld and based on observations from @Dirbaio, it was noted that the throughput of Smoltcp has been significantly impacted by #954. Specifically, it appears that this is due to the requirement that egress is checked for every ingressed packet, where this wasn't previously the case.

It was also noted that the current return value of bool from Interface::poll() doesn't provide clear information to a user as to what they should do with that value. We likely want to provide some Enum type instead that is explicit in what the poll result is and what action the user should take. This would future-proof the network stack implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant