fix: verify that svgoConfig.plugins is an array (#397)

gregberge · Feb 16, 2020 · 88110b6 · 88110b6 · vercel · Feb 16, 2020
1 parent 96966eb
commit 88110b6
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/packages/plugin-svgo/src/index.js b/packages/plugin-svgo/src/index.js
@@ -97,7 +97,13 @@ function getFilePath(state) {
 }
 
 function getPlugins(config) {
-  return config && Array.isArray(config.plugins) ? config.plugins : []
+  if (!config || !config.plugins) {
+    return []
+  }
+  if (!Array.isArray(config.plugins)) {
+    throw Error("`svgoConfig.plugins` must be an array")
+  }
+  return config.plugins
 }
 
 function extendPlugins(...configs) {

diff --git a/packages/plugin-svgo/src/index.test.js b/packages/plugin-svgo/src/index.test.js
@@ -38,6 +38,20 @@ describe('svgo', () => {
     expect(result).toMatchSnapshot()
   })
 
+  it('should throw error for invalid config.svgoConfig', () => {
+    const svgoOptions = [
+      baseSvg,
+      {
+        svgo: true,
+        runtimeConfig: true,
+        svgoConfig: { plugins: { removeDesc: false } },
+      },
+      {},
+    ]
+
+    expect(() => svgo(...svgoOptions)).toThrow()
+  })
+
   it('should support icon with config.svgoConfig plugins', () => {
     const result = svgo(
       baseSvg,