<title> should be stripped if there is none #333
Labels
Comments
|
Hello @inssein, yes we can completely strip the tag if it causes some unexpected bug like yours. Could you submit a PR to strip it if not needed? |
gregberge
pushed a commit
that referenced
this issue
Sep 24, 2019
Currently when no title is passed and titleProp is set to `true`, we are rendering an empty title element which is causing some issues. So we have added a conditional statement for rendering the title element only if the title props is not falsy. If we have an existing title, that will rendered by default. Passing the `null` values as the title will cause also cause the title element for not render even if a default title exists on the svg Fixes #333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
When creating buttons for our application, we do something like:
The above causes the output svg to contain a blank title (
<title></title>), which in Chrome, stops the tooltip from showing up.What if we completely stripped the title tag when it is undefined?
To Reproduce
Start a project with create-react-app, import an svg component and use it without a title attribute.
The text was updated successfully, but these errors were encountered: