Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifying IPC Sender, Encrypting Cookies, Electron.js/Chromium Versions #282

Open
masood opened this issue Nov 4, 2023 · 1 comment
Open

Comments

@masood
Copy link

masood commented Nov 4, 2023

Summary:
Thank you for designing the Fifo Browser Desktop Application and making it open source and available. The browser does a great job of using secure preferences when the user navigates to arbitrary websites. However, we list pointers of concern below that can help make the application more secure.

  1. [IPC Messages]: Since the application uses custom IPC and allows navigation to arbitrary sites, it will be helpful to verify the sender of IPC messages before handling and responding to them in IPC Main. [Link]
  2. [Encrypting Cookies]: The browser stores sensitive cookies on the filesystem. It will be helpful to use a fuse to encrypt cookies. [Link]
  3. [Keeping up-to-date w/ Chromium]: The application uses an old version of Electron.js and Chromium which is vulnerable to numerous known V8 and Blink attacks. We observed an existing pull request for the same, which will be great for the app. [Link]

Thank you!

Platform(s) Affected:
Windows, Linux


Mir Masood Ali, PhD student, University of Illinois at Chicago
Mohammad Ghasemisharif, PhD Candidate, University of Illinois at Chicago
Chris Kanich, Associate Professor, University of Illinois at Chicago
Jason Polakis, Associate Professor, University of Illinois at Chicago

@snaildos
Copy link
Owner

snaildos commented Nov 4, 2023

Summary: Thank you for designing the Fifo Browser Desktop Application and making it open source and available. The browser does a great job of using secure preferences when the user navigates to arbitrary websites. However, we list pointers of concern below that can help make the application more secure.

  1. [IPC Messages]: Since the application uses custom IPC and allows navigation to arbitrary sites, it will be helpful to verify the sender of IPC messages before handling and responding to them in IPC Main. [Link]
  2. [Encrypting Cookies]: The browser stores sensitive cookies on the filesystem. It will be helpful to use a fuse to encrypt cookies. [Link]
  3. [Keeping up-to-date w/ Chromium]: The application uses an old version of Electron.js and Chromium which is vulnerable to numerous known V8 and Blink attacks. We observed an existing pull request for the same, which will be great for the app. [Link]

Thank you!

Platform(s) Affected: Windows, Linux

– Mir Masood Ali, PhD student, University of Illinois at Chicago Mohammad Ghasemisharif, PhD Candidate, University of Illinois at Chicago Chris Kanich, Associate Professor, University of Illinois at Chicago Jason Polakis, Associate Professor, University of Illinois at Chicago

Hey, thank you so much for reaching out to create a list of issues with the browser. I really appreciate the research put into this.

  1. Is 100% on our watch list.
  2. is a feature I think is great, and will look into the feature.
    Regarding 3, I understand it may sound easy, however these major jumps cause a ton of side effects and electron moves really fast for just me whose maintaing the app, so I struggle to keep up. We do have a development branch (I'm pretty sure, I just came back from holidays recently) bumping the electron version and keeping compatability. So I'll look into that for you, and I am aware of the issues.

Thank you so much again, I heavily appreciate it, and I will keep this issue open for future research and comments.

Kind regards,
Snail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants