-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instagram->HTML: photos with no caption are missing a blank name property #131
Comments
🎵 hello implied discussed in IRC. evidently this is a good example of how the original implied |
@kartikprabhu says https://github.com/kartikprabhu/mf2py/tree/implied-name-fix might fix this! |
@kartikprabhu i tried that branch just now, and it works great! e.g. on https://granary.io/instagram/kevinmarks/@self/@app/BfTlf3xBF2A?format=html , it omits personally, other than that, the main mf2py issue i'd love to see happen is microformats/mf2py#83 . with that, and officially moving the repo to the microformats org, i'd be very happy! |
...also, of course, i've now realized that while this mf2py feature is great, it doesn't actually quite fix this issue, since this is on the consuming side, where i don't control the parser. @aaronpk, depending on your usage, you might consider asking granary for adding blank |
@snarfed thanks for testing. I think with mf2py not including the |
@kartikprabhu definitely! mf2py consumers at least. |
That's great news! And yes, I was specifically asking for the blank p-name property to be added to the HTML so that parsers that haven't updated for the new implied name parsing rules will still get a result that looks good. |
@snarfed just so you know I have moved all experimental coding ( basically things not officially in the mf2 spec ) to https://github.com/kartikprabhu/mf2py/tree/experimental |
Currently when there is no caption on a photo, there is no
p-name
class set, so the Microformats parser ends up with an implied name that includes all the "liked by ___" junk. Simple fix is to include an emptyp-name
element so that the consumer will see the blank name property.The text was updated successfully, but these errors were encountered: