Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction method case sensitivity #10

Open
vedeja opened this issue Oct 2, 2019 · 4 comments
Open

Interaction method case sensitivity #10

vedeja opened this issue Oct 2, 2019 · 4 comments

Comments

@vedeja
Copy link

vedeja commented Oct 2, 2019 •
edited
Loading

When using the verifier on some pact.json generated by another pact implementation, the method may not be all upper case. I am not sure if this is per specification or not but maybe it should be insensitive to the case.

https://github.com/GooRiOn/Pactify/blob/f75774707b3c7e2d8f30af49b97b107d05036203/src/Pactify/Verifiers/HttpInteractionVerifier.cs#L126
@vedeja
Copy link
Author

vedeja commented Oct 3, 2019

@GooRiOn Can I offer you a pull request?

@GooRiOn
Copy link
Member

GooRiOn commented Oct 4, 2019

@vedeja sure, go ahead :)

@vedeja
Copy link
Author

vedeja commented Oct 7, 2019

@GooRiOn , I'm new at github contribution, but I think you need to give me permissions to push.

@GooRiOn
Copy link
Member

GooRiOn commented Nov 9, 2019

@vedeja you need to do a pull request ;) Simply create a branch from master and once you finish, go to Pull Requests and create one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GooRiOn @vedeja