Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newer version of d3graph #4

Merged

Conversation

kujbol
Copy link

@kujbol kujbol commented Sep 26, 2023

D3graph library upgrade

  1. streamlit-d3graph is no longer working with newer versions of D3graph library. It's because the newer version of d3graph changed their jinja template and it's no longer compatible with the code
  2. With changes of d3graph it's possible now to re-use more parts and simplify the streamlit wrapper.
  3. Example has been updated - newer version of d3graph requires few extra libraries for using the examples (scipy, scikit-learn)

@snehankekre snehankekre self-requested a review September 27, 2023 05:50
Copy link
Owner

@snehankekre snehankekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't thank you enough for breathing life back into this component, @kujbol! 😄

The changes LGTM. Will merge this PR and try to update the release on PyPI.

@snehankekre snehankekre merged commit fc80a47 into snehankekre:main Sep 27, 2023
This was referenced Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants