Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to hydro #1

Merged
merged 1 commit into from
May 13, 2014
Merged

upgrade to hydro #1

merged 1 commit into from
May 13, 2014

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented May 13, 2014

here is the catkinized version of your package

sniekum added a commit that referenced this pull request May 13, 2014
@sniekum sniekum merged commit 2824050 into sniekum:master May 13, 2014
@sniekum
Copy link
Owner

sniekum commented May 13, 2014

Thanks!

@k-okada k-okada deleted the hydro branch May 16, 2014 02:49
@k-okada
Copy link
Contributor Author

k-okada commented May 16, 2014

thanks for accepting PR, do you have plant to release this as deb using bloom?
http://wiki.ros.org/bloom/Tutorials/FirstTimeRelease

@sniekum
Copy link
Owner

sniekum commented May 16, 2014

I won't be able to get to it for quite a while, as I have a lot of travel
coming up. I think you can release it without being the owner of the repo,
right?

--Scott

On Thu, May 15, 2014 at 10:50 PM, Kei Okada notifications@github.comwrote:

thanks for accepting PR, do you have plant to release this as deb using
bloom?
http://wiki.ros.org/bloom/Tutorials/FirstTimeRelease


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-43290237
.

@k-okada
Copy link
Contributor Author

k-okada commented May 16, 2014

ok, could you create ml_classfiers-release repo and give me permission? of course we can create release repo under my account but it may be confusing.

@sniekum
Copy link
Owner

sniekum commented May 16, 2014

Done.

On Thu, May 15, 2014 at 10:56 PM, Kei Okada notifications@github.comwrote:

ok, could you create ml_classfiers-release repo and give me permission? of
course we can create release repo under my account but it may be confusing.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-43290622
.

@k-okada
Copy link
Contributor Author

k-okada commented May 16, 2014

thanks. one more thing, you need to create tag for new release.

@sniekum
Copy link
Owner

sniekum commented May 16, 2014

I'm not sure what you mean, can you be more specific?

On Fri, May 16, 2014 at 12:39 AM, Kei Okada notifications@github.comwrote:

thanks. one more thing, you need to create tag for new release.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-43296384
.

@k-okada
Copy link
Contributor Author

k-okada commented May 16, 2014

sorry, please create tag in your git repository, we also need update
version number in
https://github.com/sniekum/ml_classifiers/blob/master/package.xml#L3

git clone https://github.com/sniekum/ml_classifiers.git
cd ml_classifieres
git tag ml_classifiers-0.3.0
git push --tag

On Fri, May 16, 2014 at 2:59 PM, Scott Niekum notifications@github.comwrote:

I'm not sure what you mean, can you be more specific?

On Fri, May 16, 2014 at 12:39 AM, Kei Okada notifications@github.comwrote:

thanks. one more thing, you need to create tag for new release.


Reply to this email directly or view it on GitHub<
https://github.com/sniekum/ml_classifiers/pull/1#issuecomment-43296384>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-43299822
.

@sniekum
Copy link
Owner

sniekum commented May 16, 2014

Done. Let me know if you need anything else.

On Fri, May 16, 2014 at 2:09 AM, Kei Okada notifications@github.com wrote:

sorry, please create tag in your git repository, we also need update
version number in
https://github.com/sniekum/ml_classifiers/blob/master/package.xml#L3

git clone https://github.com/sniekum/ml_classifiers.git
cd ml_classifieres
git tag ml_classifiers-0.3.0
git push --tag

On Fri, May 16, 2014 at 2:59 PM, Scott Niekum notifications@github.comwrote:

I'm not sure what you mean, can you be more specific?

On Fri, May 16, 2014 at 12:39 AM, Kei Okada notifications@github.comwrote:

thanks. one more thing, you need to create tag for new release.


Reply to this email directly or view it on GitHub<
https://github.com/sniekum/ml_classifiers/pull/1#issuecomment-43296384>
.


Reply to this email directly or view it on GitHub<
https://github.com/sniekum/ml_classifiers/pull/1#issuecomment-43299822>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-43300290
.

@k-okada
Copy link
Contributor Author

k-okada commented May 16, 2014

thanks, done -> ros/rosdistro#4314

On Sat, May 17, 2014 at 12:17 AM, Scott Niekum notifications@github.comwrote:

Done. Let me know if you need anything else.

On Fri, May 16, 2014 at 2:09 AM, Kei Okada notifications@github.com
wrote:

sorry, please create tag in your git repository, we also need update
version number in
https://github.com/sniekum/ml_classifiers/blob/master/package.xml#L3

git clone https://github.com/sniekum/ml_classifiers.git
cd ml_classifieres
git tag ml_classifiers-0.3.0
git push --tag

On Fri, May 16, 2014 at 2:59 PM, Scott Niekum notifications@github.comwrote:

I'm not sure what you mean, can you be more specific?

On Fri, May 16, 2014 at 12:39 AM, Kei Okada notifications@github.comwrote:

thanks. one more thing, you need to create tag for new release.


Reply to this email directly or view it on GitHub<
https://github.com/sniekum/ml_classifiers/pull/1#issuecomment-43296384>

.


Reply to this email directly or view it on GitHub<
https://github.com/sniekum/ml_classifiers/pull/1#issuecomment-43299822>
.


Reply to this email directly or view it on GitHub<
https://github.com/sniekum/ml_classifiers/pull/1#issuecomment-43300290>
.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-43343420
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants