From 400833f83406eb637a5a41e16853cb90519ed465 Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Wed, 11 Dec 2024 16:14:06 -0800 Subject: [PATCH 1/2] reversed order of the acceptance and note paramter --- app/Listeners/CheckoutableListener.php | 2 +- app/Mail/CheckoutLicenseMail.php | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/app/Listeners/CheckoutableListener.php b/app/Listeners/CheckoutableListener.php index ce3299e7d16..8e9c6c25653 100644 --- a/app/Listeners/CheckoutableListener.php +++ b/app/Listeners/CheckoutableListener.php @@ -282,7 +282,7 @@ private function getCheckoutMailType($event, $acceptance){ ]; $mailable= $lookup[get_class($event->checkoutable)]; - return new $mailable($event->checkoutable, $event->checkedOutTo, $event->checkedOutBy, $event->note, $acceptance); + return new $mailable($event->checkoutable, $event->checkedOutTo, $event->checkedOutBy, $acceptance, $event->note); } private function getCheckinMailType($event){ diff --git a/app/Mail/CheckoutLicenseMail.php b/app/Mail/CheckoutLicenseMail.php index cc91f990e1d..9462c6c332c 100644 --- a/app/Mail/CheckoutLicenseMail.php +++ b/app/Mail/CheckoutLicenseMail.php @@ -27,7 +27,6 @@ public function __construct(LicenseSeat $licenseSeat, $checkedOutTo, User $check $this->note = $note; $this->target = $checkedOutTo; $this->acceptance = $acceptance; - $this->settings = Setting::getSettings(); } From 3264149a2ccd180c0ff8cb8046f6b79fd81ca322 Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Wed, 11 Dec 2024 16:26:18 -0800 Subject: [PATCH 2/2] fix other mailables --- app/Mail/CheckoutAccessoryMail.php | 2 +- app/Mail/CheckoutAssetMail.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Mail/CheckoutAccessoryMail.php b/app/Mail/CheckoutAccessoryMail.php index f7996c54306..64c02e31ed1 100644 --- a/app/Mail/CheckoutAccessoryMail.php +++ b/app/Mail/CheckoutAccessoryMail.php @@ -21,7 +21,7 @@ class CheckoutAccessoryMail extends Mailable /** * Create a new message instance. */ - public function __construct(Accessory $accessory, $checkedOutTo, User $checkedOutBy,$note, $acceptance) + public function __construct(Accessory $accessory, $checkedOutTo, User $checkedOutBy, $acceptance, $note) { $this->item = $accessory; $this->admin = $checkedOutBy; diff --git a/app/Mail/CheckoutAssetMail.php b/app/Mail/CheckoutAssetMail.php index 71688ecb30f..680014dcd18 100644 --- a/app/Mail/CheckoutAssetMail.php +++ b/app/Mail/CheckoutAssetMail.php @@ -23,7 +23,7 @@ class CheckoutAssetMail extends Mailable /** * Create a new message instance. */ - public function __construct(Asset $asset, $checkedOutTo, User $checkedOutBy, $note, $acceptance) + public function __construct(Asset $asset, $checkedOutTo, User $checkedOutBy, $acceptance, $note) { $this->item = $asset; $this->admin = $checkedOutBy;