Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing node type: AddV2 #180

Closed
hrydgard opened this issue Oct 15, 2019 · 2 comments · Fixed by #181
Closed

Missing node type: AddV2 #180

hrydgard opened this issue Oct 15, 2019 · 2 comments · Fixed by #181

Comments

@hrydgard
Copy link
Contributor

hrydgard commented Oct 15, 2019 •
edited
Loading

Tensorflow 2 has started outputting a new kind of Add node, AddV2, here and there, which seems to be the same. It's not yet supported by Tract. It might be possible to, as a first step, simply accept AddV2 as an alternate name for Add but otherwise treat it the same, but I'm not 100% sure about this.
@hrydgard hrydgard mentioned this issue Oct 15, 2019
Open
@kali
Copy link
Collaborator

kali commented Oct 15, 2019

I agree it does look the same. If you want to try it on your side and check you get the expected result, it's as simple as registering the operator in tensorflow/src/ops/math.rs. It would be nice if you can confirm it does what you expect before I add it as I don't have much to check it. You'll also notice that there is already a BiasAdd that is the same as Add...

Waiting for the PR :)

@hrydgard hrydgard mentioned this issue Oct 15, 2019
Merged
@hrydgard
Copy link
Contributor Author

PR is there, and it works fine :)

@kali kali closed this as completed in #181 Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial support for AddV2
2 participants
@kali @hrydgard