Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refined iac test action readme [CFG-1631] #112

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Conversation

ofekatr
Copy link
Contributor

@ofekatr ofekatr commented Nov 28, 2022

What this does

  • Updates the example to not specify a path, scanning the whole repo by default.
  • Clarifies the file input arg supports multiple paths for both directories and files.
  • Adds more examples of the action with key features: Sharing CLI test results to the platform, and adding a scan mode for Terraform Plan.
  • Adds references to the docs for more information.

Background context

  • The current examples show:
    • Scanning a specific file.
    • Using --severity-threshold.
    • Multiple files - one by one, when we actually support multiple paths with a single execution.
    • Integrating GitHub Code Scanning.
  • The default experience for this GitHub action should be to scan directories by default.
  • Additionally, we do not show how to use the other flags that we support such as --scan and --report

Additional Information

@ofekatr ofekatr force-pushed the fix/iac-test-readme branch 8 times, most recently from c13feda to 17452db Compare November 28, 2022 15:22
@ofekatr ofekatr changed the title fix: refined iac test action readme fix: refined iac test action readme [CFG-1631] Nov 28, 2022
@ofekatr ofekatr marked this pull request as ready for review November 28, 2022 15:28
@ofekatr ofekatr requested a review from a team as a code owner November 28, 2022 15:28
@ofekatr ofekatr requested a review from YairZ101 November 28, 2022 15:29
Copy link

@YairZ101 YairZ101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In each of your examples you need to add a step that will checkout the code, without it technically our action will not work because it won't have something to scan.

@ofekatr ofekatr force-pushed the fix/iac-test-readme branch from 17452db to 1b2ee8a Compare November 29, 2022 09:24
@ofekatr ofekatr requested a review from YairZ101 November 29, 2022 09:25
Copy link

@YairZ101 YairZ101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small comment I left it looks good, great job keeping it up to date! 🔥

@ofekatr ofekatr force-pushed the fix/iac-test-readme branch from 1b2ee8a to fa1c578 Compare November 29, 2022 09:37
@ofekatr ofekatr merged commit 1cc9026 into master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants