Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return fix summary & meta #1716

Merged
merged 2 commits into from
Mar 12, 2021
Merged

feat: return fix summary & meta #1716

merged 2 commits into from
Mar 12, 2021

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Mar 12, 2021

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • rename outputs from snykFix package
  • return some meta about how much was fixed vs failed to be used as analytics / summary
  • optionally return output stripped of ansi characters

@lili2311 lili2311 self-assigned this Mar 12, 2021
@lili2311 lili2311 requested a review from a team March 12, 2021 15:30
@lili2311 lili2311 force-pushed the feat/return-fix-summary branch from bd8e5d2 to bdbe589 Compare March 12, 2021 16:05
@lili2311 lili2311 force-pushed the feat/return-fix-summary branch from 7616ec9 to fd209c9 Compare March 12, 2021 16:25
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2021

Expected release notes (by @lili2311)

features:
return fix summary & meta (bdbe589)
delete vuln paths option once transformed (442e37f)

fixes:
redirect ora output to stdout (fd209c9)

others (will not be included in Semantic-Release notes):
update Protect types (15dce36)
set default test options (4c3fbf9)
Remove writeable stream to skip writing tarball to the disk. (c1ca6d4)
install AWS CLI in the release step (d2266c1)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@lili2311 lili2311 merged commit 28711d3 into master Mar 12, 2021
@lili2311 lili2311 deleted the feat/return-fix-summary branch March 12, 2021 17:49
This was referenced Mar 12, 2021
This was referenced Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants