-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine.io: Cannot read properties of undefined (reading 'end') error #4643
Comments
The class used to accumulate the response headers did not expose the exact same API as its wrapped type, which could lead to the following error in some rare cases: > TypeError: Cannot read properties of undefined (reading 'end') > at Polling.onDataRequest (build/transports-uws/polling.js:109:53) > at Polling.onRequest (build/transports-uws/polling.js:47:18) > at callback (build/userver.js:94:56) > at uServer.verify (build/server.js:152:9) Related: socketio/socket.io#4643
I think I've found the culprit, this should be fixed by socketio/engine.io@8b22162, included in Please reopen if needed. |
not, it does not fix that, also there is other error with uws |
we are facing a similar issues
|
For future readers: The exception seems to come from this line:
Though I'm not sure how I do think the initial issue was fixed though. Please reopen if needed. |
Describe the bug
We're sometimes seeing a very rare error while using uWebSockets.js (uws);
To Reproduce
It happens occasionally and can't reproduce locally
Socket.IO server version:
4.6.0
Expected behavior
No to see the error or this error gets handled gracefully.
Platform:
Additional context
Cannot read properties of undefined (reading 'end')\nTypeError: Cannot read properties of undefined (reading 'end')\n at Polling.onDataRequest (/node_modules/engine.io/build/transports-uws/polling.js:104:51)\n at Polling.onRequest (/node_modules/engine.io/build/transports-uws/polling.js:47:18)\n at /node_modules/engine.io/build/userver.js:95:60\n at uServer.verify (/node_modules/engine.io/build/server.js:152:9)\n at /node_modules/engine.io/build/userver.js:82:18\n at /node_modules/engine.io/build/userver.js:74:13\n at /node_modules/engine.io/build/server.js:187:21\n at cors (/node_modules/cors/lib/index.js:188:7)\n at /node_modules/cors/lib/index.js:224:17\n at origin (/dist/socket.js:40:25)
The text was updated successfully, but these errors were encountered: