Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nio4r 2.7.2 broken on JRuby #315

Closed
jsvd opened this issue May 7, 2024 · 4 comments
Closed

nio4r 2.7.2 broken on JRuby #315

jsvd opened this issue May 7, 2024 · 4 comments
Milestone

Comments

@jsvd
Copy link

jsvd commented May 7, 2024

hi @ioquatix I believe the latest changes to the gem structure have broken the jruby gem.
For example the gem doesn't include the gemspec any more:

❯ for gem in nio4r-2.7.1-java.gem nio4r-2.7.2-java.gem ; do gem unpack $gem;done
Unpacked gem: '/private/tmp/nio4r/nio4r-2.7.1-java'
Unpacked gem: '/private/tmp/nio4r/nio4r-2.7.2-java'

❯ find . -name "*gemspec"                                                       
./nio4r-2.7.1-java/nio4r.gemspec

And fails to install as it tries to install the C extensions:

❯ gem install nio4r -v 2.7.2
Building native extensions. This could take a while...
ERROR:  Error installing nio4r:
	ERROR: Failed to build gem native extension.

    current directory: /Users/joaoduarte/.rvm/gems/jruby-9.4.6.0/gems/nio4r-2.7.2-java/ext/nio4r
/Users/joaoduarte/.rvm/rubies/jruby-9.4.6.0/bin/jruby -I /Users/joaoduarte/.rvm/rubies/jruby-9.4.6.0/lib/ruby/stdlib extconf.rb
checking for unistd.h... *** extconf.rb failed ***
@chadlwilson
Copy link

Oops, duplicated with a commit comment at 769c298#r141766031 which seems to me to be the relevant change - it's now trying to build native extensions which it did not used to do?

@ioquatix
Copy link
Member

ioquatix commented May 7, 2024

Apologies, I'll sort this out today.

@ioquatix
Copy link
Member

ioquatix commented May 7, 2024

This should be fixed in 2.7.3 but can you please test it and let me know - thanks!

@ioquatix ioquatix added this to the v2.7.3 milestone May 7, 2024
@chadlwilson
Copy link

chadlwilson commented May 8, 2024

2.7.3 seems fine, thanks a lot @ioquatix !

👋 @ 🥝 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants