Connection aborted due to invalid data in the socket in Firefox

[miketaylr]

This bug was filed @ https://bugzilla.mozilla.org/show_bug.cgi?id=1536843 and also facebook/create-react-app#6720, but it seems like the bug is here in sockjs-client (I think?).

There's STR in https://bugzilla.mozilla.org/show_bug.cgi?id=1536843#c0.

It shows that the websocket handshake is successful, few frames are received, but then the connection is aborted due to invalid data in the socket.

In the end, I was able to reproduce it and mozregression pointed to a bug 1417463. That bug changed default accept header and further testing showed that it's server side issue. For some reason, server goes mad when "text/html" is missing in the accept header and after few frames it sends some unexpected HTTP response over the websocket connection.

I.e. this bug happens in Firefox 65 too when text/html is removed from network.http.accept.default pref in about:config.

[brycekahle]

@miketaylr Those comments seem to indicate a server issue? If that is correct, it is not a bug in sockjs-client.

[daliusd]

Yes, I think this might be webpack-dev-server issue, but I'm not sure.

[alexander-akait]

@brycekahle Nope, problem here

[brycekahle]

@evilebottnawi Please explain. The comments above clearly reference a "server side issue", which would not be the JS client.

[dmile]

Connection aborted because webpack-dev-server trying to proxy sockjs request

1. When proxy enabled webpack-dev-server uses http-proxy-middleware
2. http-proxy-middleware checks every request with shouldProxy and result depends on proxy context
3. Default proxy context defined in react-dev-utils and rely on accept header
4. The header is different for browsers

Firefox 65.0.2

Firefox 66.0.3

Hope it helps.

[dmile]

Interesting that Safari doesn't send accept header at all.
In that case context / sholdProxy becomes undefined and works fine in if condition with enabling HPM stuff 🙂

[brycekahle]

@dmile Thanks for the info. That seems to indicate the problem lies in react-dev-utils then. Would you agree?

[dmile]

It's an integration issue. But I agree, react-dev-utils is a place where it occurs.

[brycekahle]

I'm going to close this issue since the problem lies elsewhere.