-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add automated tests for main methods, add domain dataset(s) #326
Comments
@PetrKorab Thanks for your comments. Could you elaborate in more detail which automated tests you are missing? We currently have >90% coverage and they are tested automatically with GitHub actions. Which main methods do you find untested? |
@qubixes Please add here a link to a folder with automated tests (JOSS submission) showing Metasyn's functionality on at least one other domain dataset (except the Titanic one). Thanks. |
The link to our test folder is https://github.com/sodascience/metasyn/tree/develop/tests for our development branch. I have added a medical dataset in #330, would that suffice as another domain dataset to you? |
@PetrKorab we have extensive automated tests in our tests folder, and we have now additionally documented them with docstrings based on your feedback. Our tests include:
In addition, our continuous integration includes linting, type checking, formatting, documentation building, and running the example jupyter notebook from our examples folder. See core-ci.yml Data is available to everyone in this way: from metasyn import demo_dataframe
df = demo_dataframe("hospital")
print(df)
I hope this answers your comment in a satisfactory way! |
Add automated tests covering the main Metasyn's methods, in line with JOSS guidelines. Also, please add tests for at least one domain dataset where you show the benefits of the programme. Make the data available to the reviewers, if possible. Thanks!
The text was updated successfully, but these errors were encountered: