Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong max and core values in http server config #708

Closed
elseifer opened this issue Sep 9, 2020 · 0 comments · Fixed by #709
Closed

wrong max and core values in http server config #708

elseifer opened this issue Sep 9, 2020 · 0 comments · Fixed by #709
Assignees
@elseifer
Labels
bug Something isn't working
Milestone
3.4.5

Comments

@elseifer
Copy link
Member

elseifer commented Sep 9, 2020 •
edited
Loading

in com.alipay.sofa.rpc.boot.container.ServerConfigContainer#createHttpServerConfig, here are some wrong codes:

if (StringUtils.hasText(httpThreadPoolCoreSizeStr)) {
     serverConfig.setMaxThreads(Integer.parseInt(httpThreadPoolCoreSizeStr));
}
if (StringUtils.hasText(httpThreadPoolMaxSizeStr)) {
    serverConfig.setCoreThreads(Integer.parseInt(httpThreadPoolMaxSizeStr));
}
@elseifer elseifer added the bug Something isn't working label Sep 9, 2020
@elseifer elseifer self-assigned this Sep 9, 2020
@elseifer elseifer added this to the 3.4.5 milestone Sep 9, 2020
@elseifer elseifer mentioned this issue Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elseifer elseifer

Labels
bug Something isn't working
Projects
None yet
Milestone
3.4.5
Development

Successfully merging a pull request may close this issue.

fix bug: wrong max and core size of thread pool in http config elseifer/sofa-boot
1 participant
@elseifer