Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generation of CGMES profile class #39

Merged

Conversation

tom-hg57
Copy link
Collaborator

@tom-hg57 tom-hg57 commented Aug 11, 2024

Depends on cimgen pull request: sogno-platform/cimgen#35, which is already merged now.

In my repo all workflows run successfully: tom-hg57#1 (even deploying of github-pages).

Improve cimexport.py using profile URIs (from new generated CGMESProfile.py) in model description of exported cim files

  • Update generated python files created by cimgen
  • Use profile URIs (from new generated CGMESProfile.py) in model description of exported cim files
  • Fix "Package information not found" for EquipmentBoundary and ToplogyBoundary in cim_import() by using new generated CGMESProfile.py
  • Fix export for data read without profile information
  • Improve cim_export (activeProfileList is now optional - no activeProfileList means output to all profile files with data)
  • Add function cim_export_to_string_array
  • Fix model ID in cim_export (must be unique across all files)
  • Use recommended class profile from new generated classes (if data is read without profile information, or some objects are added after import)
  • Improve .github/workflows/test.yaml
  • Update documentation in cimpy/cimexport.py

With the new generated python files created by cimgen the issue #23 is solved. PR #24 could be closed if this PR is merged.

The same applies to issue #25 and PR #26.

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
…ption of exported cim files

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
…dd method Profile.uris() to CGMESProfile.py to get the list of profile URIs)

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@stv0g stv0g changed the title Add generation of cgmes profile class Add generation of CGMES profile class Aug 13, 2024
…Boundary in cim_import() by using new generated CGMESProfile.py

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
…ileList means output to all profile files with data)

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
…enerated classes)

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
…read without profile information, or some objects are added after import)

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
@tom-hg57
Copy link
Collaborator Author

Ready for review.

Signed-off-by: Thomas Günther <tom@toms-cafe.de>
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
Signed-off-by: Thomas Günther <tom@toms-cafe.de>
Copy link

sonarcloud bot commented Aug 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tom-hg57
Copy link
Collaborator Author

tom-hg57 commented Aug 16, 2024

In my repo all workflows run successfully: tom-hg57#1

@m-mirz m-mirz requested a review from stv0g September 21, 2024 17:49
m-mirz added a commit to sogno-platform/cimgen that referenced this pull request Sep 29, 2024
- Add generation of CGMESProfile class (including profile URIs) for
python
- Improve generation of CGMESProfile class for javascript
- Add cim namespace to the generated CGMESProfile class
- Add method Profile.uris() to CGMESProfile.py to get the list of
profile URIs
- Add recommended class profile to all generated classes (currently only
used for python: sogno-platform/cimpy#39)
@m-mirz m-mirz merged commit 0b78484 into sogno-platform:master Oct 30, 2024
1 of 2 checks passed
@tom-hg57 tom-hg57 deleted the add-generation-of-CGMESProfile-class branch October 31, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants