Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: onProgramAccountChange() and onAccountChange() now accept an encoding #2861

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: onProgramAccountChange() and onAccountChange() now accept an encoding #2861

merged 1 commit into from
Jun 27, 2024
+195 −6

Conversation

steveluscher
Copy link
Collaborator

Fixes #2725.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d91a9af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@steveluscher Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

@steveluscher steveluscher force-pushed the 06-26-fix_onprogramaccountchange_and_onaccountchange_now_accept_an_encoding branch from e6a5f7e to cbb3595 Compare June 26, 2024 21:45
steveluscher
steveluscher commented Jun 26, 2024
View reviewed changes
packages/library-legacy/src/connection.ts
Comment on lines 6380 to +6384
onAccountChange(
publicKey: PublicKey,
callback: AccountChangeCallback,
commitment?: Commitment,
): ClientSubscriptionId;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing method signature for backward compatibility.

packages/library-legacy/src/connection.ts
Comment on lines 6457 to +6461
onProgramAccountChange(
programId: PublicKey,
callback: ProgramAccountChangeCallback,
commitment?: Commitment,
filters?: GetProgramAccountsFilter[],
): ClientSubscriptionId;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing method signature for backward compatibility.

packages/library-legacy/src/connection.ts
Comment on lines +6476 to +6479
config
? config
: maybeFilters
? {filters: maybeFilters}
: undefined /* extra */,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to TypeScript, you either have a config, or you have commitment/filters, but never both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little gross, but wfm.

@steveluscher steveluscher requested a review from buffalojoec June 26, 2024 21:47
@steveluscher steveluscher force-pushed the 06-26-fix_onprogramaccountchange_and_onaccountchange_now_accept_an_encoding branch from cbb3595 to d91a9af Compare June 26, 2024 21:57
buffalojoec
buffalojoec approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

packages/library-legacy/src/connection.ts
commitment?: Commitment;
/**
* Encoding format for Account data
* - `base58` is slow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I laughed at this, until I realized it's actually what's in the docs. 😅

packages/library-legacy/src/connection.ts
Comment on lines +6476 to +6479
config
? config
: maybeFilters
? {filters: maybeFilters}
: undefined /* extra */,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little gross, but wfm.

@steveluscher steveluscher merged commit f9b0d6d into master Jun 27, 2024
8 checks passed
@steveluscher steveluscher deleted the 06-26-fix_onprogramaccountchange_and_onaccountchange_now_accept_an_encoding branch June 27, 2024 14:32
@github-actions GitHub Actions
Copy link
Contributor

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buffalojoec buffalojoec buffalojoec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WSS method onAccountChange doesn't support custom encoding
2 participants
@steveluscher @buffalojoec