Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rent should only be collected per block (not per transaction) #10088

Closed
jstarry opened this issue May 17, 2020 · 6 comments
Closed

Rent should only be collected per block (not per transaction) #10088

jstarry opened this issue May 17, 2020 · 6 comments
Labels
locked issue stale [bot only] Added to stale content; results in auto-close after a week.
Milestone

Comments

@jstarry
Copy link
Member

jstarry commented May 17, 2020

Problem

Rent is a protocol thing that happens to accounts outside of transactions but currently is closely tied to account creation transactions. This is an issue for a few reasons:

  1. Accounts could be charged rent more than once per block (if created / destroyed / created again)
  2. Rent affects the postBalance field in stored transaction status metadata and this effect is not currently transparent to clients (see: https://github.com/solana-labs/explorer/issues/118)
  3. Tying rent collection to transactions is inconsistent with how eager rent collection works (per block)

Proposed Solution

Instead of collecting rent during each transaction which creates accounts, wait to collect rent from newly created accounts until the end of a block.

@sakridge
Copy link
Member

The end-of-block rent only collects for a subset of account keys, so you could rotate your key in a way to avoid the rent. Thus both mechanisms are needed.

@jstarry
Copy link
Member Author

jstarry commented May 17, 2020

@sakridge I just updated the description to say "Collect rent from newly created accounts". Does that address your comment?


EDIT: Updated the description again for clarity

@jstarry
Copy link
Member Author

jstarry commented May 17, 2020

It's a separate mechanism from eager rent collection

@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Jun 2, 2021
@stale
Copy link

stale bot commented Jun 18, 2021

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Jun 18, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2022

This issue has been automatically locked since there has not been any activity in past 7 days after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked issue stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

No branches or pull requests

3 participants