Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.3: Enable retirement of rent collect in Bank::deposit() on testnet #11543

Closed
ryoqun opened this issue Aug 11, 2020 · 0 comments · Fixed by #12223
Closed

v1.3: Enable retirement of rent collect in Bank::deposit() on testnet #11543

ryoqun opened this issue Aug 11, 2020 · 0 comments · Fixed by #12223
Milestone
v1.3.10

Comments

@ryoqun
Copy link
Member

ryoqun commented Aug 11, 2020 •
edited
Loading

Problem

this needs to be updated for testnet:

solana/runtime/src/bank.rs

Line 2548 in 53e917b

OperatingMode::Preview => self.epoch() >= Epoch::max_value(),

Context

#10468

Cousin

#11545
@ryoqun ryoqun mentioned this issue Aug 11, 2020
Closed
@mvines mvines added this to the v1.3.4 milestone Aug 15, 2020
@joncinque joncinque modified the milestones: v1.3.4, v1.3.6 Aug 28, 2020
@oJshua oJshua modified the milestones: v1.3.8, v1.3.9 Sep 3, 2020
@mvines mvines modified the milestones: v1.3.9, v1.3.10 Sep 9, 2020
@ryoqun ryoqun mentioned this issue Sep 15, 2020
Merged
@mergify mergify bot closed this as completed in #12223 Sep 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.10
Development

Successfully merging a pull request may close this issue.

Enable retirement of rent collect in Bank::deposit() on testnet ryoqun/solana
4 participants
@ryoqun @oJshua @joncinque @mvines