Simplify BlockCommitmentCache slot info #11106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
approved these changes
Jul 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #11106 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 319 319
Lines 73367 73386 +19
=======================================
+ Hits 60287 60309 +22
+ Misses 13080 13077 -3 |
|
|
Perfect timing ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BlockCommitmentCache and CacheSlotInfo store the same data, but in different ways. No functional reason for this, and it just obfuscates the code.
Summary of Changes
Reorganization only: Store a CacheSlotInfo in BlockCommitmentCache.
Closes #11104