Add Vote Account Management Doc #11278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Jul 29, 2020
garious
reviewed
Jul 30, 2020
| ### Vote Account Address | ||
|
|
||
| A vote account is created at an address that is either the public key of a | ||
| keypair file, or at a derived address from the authorized voter's public key. |
t-nelson
previously requested changes
Jul 30, 2020
| ### Vote Account Address | ||
|
|
||
| A vote account is created at an address that is either the public key of a | ||
| keypair file, or at a derived address from the authorized voter's public key. |
There was a problem hiding this comment.
A derived address doesn't technically have to be based off either authority. It can be any ole keypair. Perhaps that technicality doesn't need communicated here though?
There was a problem hiding this comment.
I can leave the technicality out, but the CLI description is actually rather confusing to me, looking at it again:
--seed <STRING>
Seed for address generation; if specified, the resulting account will be at a derived address of the VOTE
ACCOUNT pubkey
That's the only place we use the term VOTE ACCOUNT in the help text. I assume this is referring to the vote account keypair positional arg? In which case my description here about deriving from the vote auth pubkey is just wrong anyway.
garious
reviewed
Jul 30, 2020
added 2 commits
July 30, 2020 20:18
garious
approved these changes
Jul 31, 2020
danpaul000
added
the
automerge
mergify bot
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Add vote account management doc * Add links to new doc * Whitespace * Fixup language * Cleaner title * Apply review feedback * Apply further feedback * Fix usage page header Co-authored-by: publish-docs.sh <maintainers@solana.com> (cherry picked from commit a5b6fd3)
mergify bot
added a commit
that referenced
this pull request
Jul 31, 2020
* Add vote account management doc * Add links to new doc * Whitespace * Fixup language * Cleaner title * Apply review feedback * Apply further feedback * Fix usage page header Co-authored-by: publish-docs.sh <maintainers@solana.com> (cherry picked from commit a5b6fd3) Co-authored-by: Dan Albert <dan@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have no doc describing the features and knobs for managing a vote account.
Summary of Changes
Add one.