Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getParsedConfirmedTransaction API #11412

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Aug 6, 2020

Problem

  • Need API for getting parsed confirmed transactions from RPC

Summary of Changes

  • Add getParsedConfirmedTransaction method to Connection

Halfway through typing up all of the token instructions, I decided to add them directly to the explorer..

  • Typing is super time intensive given our Flow / old superstruct / type def files setup
  • It probably makes more sense for these types to live in @solana/spl-token
  • I don't know of any immediate need for them inside web3

Fixes #

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #11412 into master will decrease coverage by 7.8%.
The diff coverage is 13.3%.

@@            Coverage Diff             @@
##           master   #11412      +/-   ##
==========================================
- Coverage    81.9%    74.0%    -7.9%     
==========================================
  Files         320       29     -291     
  Lines       75012     1309   -73703     
  Branches        0      154     +154     
==========================================
- Hits        61449      969   -60480     
+ Misses      13563      304   -13259     
- Partials        0       36      +36     

@jstarry jstarry requested a review from mvines August 6, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants