ensure_packages unzip with 'before' breaks interoperability

[ilyash-p]

In install.pp there is

ensure_packages(['unzip'], { 'before' => Staging::File['consul.zip'] })

which breaks interoperability since if you have

ensure_packages(['unzip'])

in any other place it's a redeclaration error (because attributes are different). Minimal code that shows similar problem:

puppet apply -e 'ensure_packages(["unzip"]) ensure_packages(["unzip"], {stage=>"main"})'

Output excerpt:

Error: Duplicate declaration: Package[unzip] is already declared

[ilyash-p]

Possible solution: "Remove management of unzip package" - danieldreier@8253cba

[solarkennedy]

Fixed by #185

[hopperd]

Closing since this is fixed.

[Cinderhaze]

There is another solution. (just ran into this in my copy of 1.0.2)

If you put the relationship after the ensure_packages, it can work without breaking other ensure_packages.

ensure_package('unzip')
Package['unzip'] -> Staging::File['consul.zip']

This allows you to still ensure that the package is managed, but doesn't cause a Duplicate Declaration error. I'm guessing it's similar to the

include 'myclass'

vs

class:{'myclass':}

schematics.

[solarkennedy]

That will still cause the duplication error if another user declares (not via ensure_packages) unzip before consul is parsed.