Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean out fixtures prior to uploading to forge #349

Closed
bodgit opened this issue Jun 30, 2017 · 2 comments
Closed

Clean out fixtures prior to uploading to forge #349

bodgit opened this issue Jun 30, 2017 · 2 comments
Assignees

Comments

@bodgit
Copy link

bodgit commented Jun 30, 2017

I noticed that your Consul module ships with all of the module fixtures intact. This caused a minor problem for me as there are .git directories in the fixtures that cause submodule warnings when pushing/pulling this module from git via an r10k workflow, but it also means your module is shipping redundant/unused copies of the stdlib and archive modules so the download size of your module is bigger than it needs to be.

Would you be against adding a step somewhere in the build process to clean these out prior to building the module tarball?

@solarkennedy
Copy link
Contributor

Huh. I use https://github.com/voxpupuli/puppet-blacksmith, I figured it would be doing the right thing.

I'll be extra careful on the next release and double check.

@solarkennedy solarkennedy self-assigned this Jun 30, 2017
@solarkennedy
Copy link
Contributor

I've cleaned this up and the most recent release does not have these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants