Update beaker tests + travis integration #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - PUPPET_VERSION="~> 3.1.0" | ||
| - PUPPET_VERSION="~> 3.3.0" | ||
| - PUPPET_VERSION="~> 3.7.4" FUTURE_PARSER=yes STRICT_VARIABLES=yes | ||
| - PUPPET_VERSION="~> 4.0.0" | ||
| - PUPPET_VERSION="~> 4.1.0" | ||
| - BEAKER=true | ||
| global: |
There was a problem hiding this comment.
may be PUPPET_VERSION=* needs to move into global as well? Currently it seems to conflict between the 2 data types; array and hash.
solarkennedy
force-pushed
the
more_beaker
branch
4 times, most recently
from
03a5df9
to
778740a
Compare
solarkennedy
changed the title
solarkennedy
force-pushed
the
more_beaker
branch
from
778740a
to
88bb33c
Compare
|
@solarkennedy niiiiiice! Let me try this again and I'll let you know in a few. |
|
I'm going to go ahead and merge this in, as they do pass and work. |
solarkennedy
added a commit
that referenced
this pull request
Sep 5, 2015
Update beaker tests + travis integration
|
@solarkennedy sorry for not getting back quickly. I had time to play around with it earlier this week and think it looks good. I'll play around with it some more this weekend. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the beaker tests to the point where they work again.
@aj-jester this is ready for review. I mostly wanted this in perpetration for integrating your work with installing zips and downgrades.
If we want to be sure that our code can fetch consul from the internet, unzip, verify, downgrade, etc, then we should describe it in code. With these this infrastructure we should be able to do that reproducibly, and if it ever breaks we will know.
Of course you can run them manually yourself if you have docker installed with
bundle exec rake beaker