Remove puppet error when ACLs cannot be retrieved #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if consul does not come up or there is some issue electing a leader, the consul_acl will throw a hard puppet error. This causes the puppet run to immediately fail. This commit changes that puppet error to a warning. The unavailability of the consul API should not cause a puppet failure.
solarkennedy
reviewed
Oct 4, 2016
| @@ -57,7 +57,9 @@ def self.list_resources(acl_api_token, port, hostname, protocol, tries) | |||
| if res.code == '200' | |||
| acls = JSON.parse(res.body) | |||
| else | |||
| raise(Puppet::Error,"Cannot retrieve ACLs: invalid return code #{res.code} uri: #{path} body: #{req.body}") | |||
| Puppet.warning("Cannot retrieve ACLs: invalid return code #{res.code} uri: #{path} body: #{req.body}") | |||
| $stderr.puts "Cannot retrieve ACLs: invalid return code #{res.code} uri: #{path} body: #{req.body}" | |||
There was a problem hiding this comment.
Do you need both the puppet warning and stderr?
There was a problem hiding this comment.
No. That must have snuck in during testing. I'll remove the stderr.
|
I don't know whats up with those test failure, let me look at those a bit and compare to master. |
spuder
pushed a commit
to spuder/puppet-consul
that referenced
this pull request
Feb 25, 2020
Remove puppet error when ACLs cannot be retrieved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if consul does not come up or there is some issue electing a
leader, the consul_acl will throw a hard puppet error. This causes the
puppet run to immediately fail. This commit changes that puppet error to
a warning. The unavailability of the consul API should not cause a
puppet failure.